Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add no-unused-expressions to recommended #1194

Closed
bradzacher opened this issue Nov 11, 2019 · 3 comments
Closed

Add no-unused-expressions to recommended #1194

bradzacher opened this issue Nov 11, 2019 · 3 comments
Labels
package: eslint-plugin Issues related to @typescript-eslint/eslint-plugin recommended-rules Discussion about recommended rule sets

Comments

@bradzacher
Copy link
Member

Added in #1175 by @Nizarius

Should be added to the eslint-recommened set.

@bradzacher bradzacher added package: eslint-plugin Issues related to @typescript-eslint/eslint-plugin recommended-rules Discussion about recommended rule sets labels Nov 11, 2019
@bradzacher bradzacher added this to the 3.0.0 milestone Nov 11, 2019
@JerryLyu93
Copy link

Or have any way to add this rule to the eslint rule list?

If a rule is not in recommended/fixable/requires type information, how can I use them?

@JerryLyu93
Copy link

THX for the docs.

I was trying to follow the docs of eslint & typescript-eslint, but the linter just keeping throw the Error Definition for rule '@typescript-eslint/no-unused-expressions' was not found.

So first I thought the reason was that I use plugin:@typescript-eslint/recommended and @typescript-eslint/no-unused-expressions is not recommended. But your reply shows the reason seems not true.

Then I found some issues like this Error. Most of them were version issues but the packages of typescript-eslint in my project seem were already up-to-date but it's not really. At last, I found the package react-scripts was depended on the 1.x @typescript-eslint/eslint-plugin. OMG monorepo always cause issues like this, and maybe I should notice not only package.json but also yarn.lock.

THX for your help again.

@bradzacher bradzacher removed this from the 3.0.0 milestone Nov 27, 2019
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 20, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
package: eslint-plugin Issues related to @typescript-eslint/eslint-plugin recommended-rules Discussion about recommended rule sets
Projects
None yet
Development

No branches or pull requests

2 participants