Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(typescript-estree): fix synthetic default import #1245

Merged

Conversation

fa93hws
Copy link
Contributor

@fa93hws fa93hws commented Nov 21, 2019

The generated .d.ts file would be something like

import * as eslintVisitorKeys from 'eslint-visitor-keys';

Which require the user to turn on allowSyntheticDefaultImports in tsconfig

otherwise they will see

node_modules/@typescript-eslint/typescript-estree/dist/visitor-keys.d.ts:1:8 - error TS1192: Module '"//tools/eslint/eslint-plugin-ts/node_modules/@types/eslint-visitor-keys/index"' has no default export.

1 import eslintVisitorKeys from 'eslint-visitor-keys';
         ~~~~~~~~~~~~~~~~~


Found 1 error.

@typescript-eslint
Copy link
Contributor

Thanks for the PR, @fa93hws!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!


🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. As a thank you, your profile/company logo will be added to our main README which receives thousands of unique visitors per day.

@codecov
Copy link

codecov bot commented Nov 21, 2019

Codecov Report

Merging #1245 into master will not change coverage.
The diff coverage is 100%.

@@           Coverage Diff           @@
##           master    #1245   +/-   ##
=======================================
  Coverage   94.23%   94.23%           
=======================================
  Files         126      126           
  Lines        5377     5377           
  Branches     1510     1510           
=======================================
  Hits         5067     5067           
  Misses        177      177           
  Partials      133      133
Impacted Files Coverage Δ
packages/typescript-estree/src/visitor-keys.ts 100% <100%> (ø) ⬆️

@bradzacher bradzacher changed the title fix(estree): change import method fix(typescript-estree): fix synthetic default import Nov 21, 2019
@bradzacher bradzacher added the bug Something isn't working label Nov 21, 2019
Copy link
Member

@bradzacher bradzacher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for this!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants