Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[constructor-super] Duplicates TypeScript's TS2335 and TS2377 errors #1248

Closed
glen-84 opened this issue Nov 22, 2019 · 1 comment
Closed
Labels
package: eslint-plugin Issues related to @typescript-eslint/eslint-plugin recommended-rules Discussion about recommended rule sets

Comments

@glen-84
Copy link
Contributor

glen-84 commented Nov 22, 2019

Repro

{
  "rules": {
    "constructor-super": "error"
  }
}
class A {
    public constructor() {
        super();
    }
}

class B extends A {
    public constructor() {
        // ...
    }
}

Expected Result

TS errors only.

Actual Result

TS and ESLint errors.

image

Additional Info

This relates to the recommended config (configs/eslint-recommended.ts).

Versions

package version
@typescript-eslint/eslint-plugin 2.8.0
@typescript-eslint/parser 2.8.0
TypeScript 3.4.5
ESLint 6.6.0
node 12.13.0
npm 6.12.0
@glen-84 glen-84 added package: eslint-plugin Issues related to @typescript-eslint/eslint-plugin triage Waiting for maintainers to take a look labels Nov 22, 2019
@bradzacher bradzacher added recommended-rules Discussion about recommended rule sets and removed triage Waiting for maintainers to take a look labels Nov 22, 2019
@bradzacher bradzacher added this to the 3.0.0 milestone Nov 22, 2019
@bradzacher
Copy link
Member

consolidated eslint-recommended changes in #1273

@bradzacher bradzacher removed this from the 3.0.0 milestone Dec 3, 2019
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 20, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
package: eslint-plugin Issues related to @typescript-eslint/eslint-plugin recommended-rules Discussion about recommended rule sets
Projects
None yet
Development

No branches or pull requests

2 participants