Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(typescript-estree): correct range of parameters with comments #128

Merged
merged 3 commits into from
Jan 22, 2019
Merged

Conversation

armano2
Copy link
Member

@armano2 armano2 commented Jan 22, 2019

This PR fixes range of TSTypeParameterInstantiation with whitespaces and comments

https://astexplorer.net/#/gist/0449cd541d283ca444c0db8f1a875510/6b31f4d39aa3f4c5ef3b235795d3e01516eb49c6

@armano2 armano2 self-assigned this Jan 22, 2019
@armano2 armano2 added the bug Something isn't working label Jan 22, 2019
@armano2 armano2 changed the title fix(ts-estree): correct range of parameters with comments fix(typescript-estree): correct range of parameters with comments Jan 22, 2019
@codecov
Copy link

codecov bot commented Jan 22, 2019

Codecov Report

Merging #128 into master will decrease coverage by 0.02%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master     #128      +/-   ##
==========================================
- Coverage    95.1%   95.08%   -0.03%     
==========================================
  Files          49       49              
  Lines        2494     2483      -11     
  Branches      374      371       -3     
==========================================
- Hits         2372     2361      -11     
  Misses         73       73              
  Partials       49       49
Impacted Files Coverage Δ
packages/typescript-estree/src/convert.ts 94.4% <100%> (-0.09%) ⬇️

@JamesHenry JamesHenry merged commit 91eedf2 into typescript-eslint:master Jan 22, 2019
@armano2 armano2 deleted the types-range branch January 22, 2019 23:34
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 21, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants