-
-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add internal eslint plugin for repo-specific lint rules #1373
Conversation
Thanks for the PR, @bradzacher! typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community. The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately. Thanks again! 🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. As a thank you, your profile/company logo will be added to our main README which receives thousands of unique visitors per day. |
Codecov Report
@@ Coverage Diff @@
## master #1373 +/- ##
==========================================
- Coverage 94.09% 94.04% -0.05%
==========================================
Files 133 139 +6
Lines 5940 5975 +35
Branches 1685 1691 +6
==========================================
+ Hits 5589 5619 +30
- Misses 187 192 +5
Partials 164 164
|
packages/eslint-plugin-internal/src/rules/no-typescript-default-import.ts
Outdated
Show resolved
Hide resolved
…t-import.ts Co-Authored-By: Armano <armano2@users.noreply.github.com>
There's a few things I want to enforce internally.
Save us from having to communicate these things in PR reviews.
import ts from 'typescript'
in packages.allowSyntheticDefaultImports
import {} from '@typescript-eslint/typescript-estree'
from the plugins, where the package isn't a dependency.Adding this in now reduces the barrier to entry, meaning we can easily add rules to warn against patterns we see people do in the future.