fix(parser): add visiting of type parameters in JSXOpeningElement #150
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #150 +/- ##
=========================================
+ Coverage 95.1% 95.1% +<.01%
=========================================
Files 49 49
Lines 2490 2493 +3
Branches 373 373
=========================================
+ Hits 2368 2371 +3
Misses 73 73
Partials 49 49
|
JamesHenry
approved these changes
Jan 27, 2019
uniqueiniquity
pushed a commit
to uniqueiniquity/typescript-eslint
that referenced
this pull request
Jan 28, 2019
…escript-eslint#173) Fixes typescript-eslint#150 Whilst `TSParameterProperty`s are arguments, they are also technically class properties. `no-unused-vars` has no handling for class properties, so just mark them as used.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds missing visitor keys to parser, and missing parameter into
JSXOpeningElementfixes: #141
cc: @claneo