Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[naming-convention] Support negative matches for filter option #1512

Closed
bradzacher opened this issue Jan 24, 2020 · 0 comments · Fixed by #1517
Closed

[naming-convention] Support negative matches for filter option #1512

bradzacher opened this issue Jan 24, 2020 · 0 comments · Fixed by #1517
Labels
enhancement: plugin rule option New rule option for an existing eslint-plugin rule package: eslint-plugin Issues related to @typescript-eslint/eslint-plugin

Comments

@bradzacher
Copy link
Member

Spinning off of #1482

Regexes are great at matching things, but they're pretty terrible for not matching things.
At the last minute before merging the rule, I added the custom field, which has the format custom: { regex: string, match: boolean }.
But I didn't think go back and add this to the filter option.

Should give the same treatment to the filter option so it's easy to include or exclude identifiers.
@bradzacher bradzacher added package: eslint-plugin Issues related to @typescript-eslint/eslint-plugin enhancement: plugin rule option New rule option for an existing eslint-plugin rule labels Jan 24, 2020
@bradzacher bradzacher mentioned this issue Jan 24, 2020
Merged
@G-Rath G-Rath mentioned this issue Jan 25, 2020
Merged
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 20, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
enhancement: plugin rule option New rule option for an existing eslint-plugin rule package: eslint-plugin Issues related to @typescript-eslint/eslint-plugin
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(eslint-plugin): support negative matches for filter
1 participant
@bradzacher