feat(eslint-plugin): add new rule no-for-in-array

[uniqueiniquity]

Adding equivalent of TSLint's no-for-in-array.

[uniqueiniquity]

@armano2 How would I test line 38 in the rule? It's not a case that would ever really get hit if typescript-estree is behaving correctly. Should I just not worry about it?

[armano2]

hmm, in most cases nodes are present, and i think you should remove this if.

we have cases of nodes not from TS, and "broken" parts of code like
https://github.com/typescript-eslint/typescript-eslint/blob/master/packages/typescript-estree/src/convert.ts#L1290

[j-f1]

Thanks for contributing! A few small suggestions/questions:

[JamesHenry]

@uniqueiniquity I think the confusion over the .md formatting has been resolved now, things should be easier once this is brought up to date with master

Thanks!

[JamesHenry]

@j-f1 @armano2 Have your concerns been addressed? Please can you update your reviews?

[codecov]

Codecov Report

Merging #155 into master will increase coverage by 0.01%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master     #155      +/-   ##
==========================================
+ Coverage   96.75%   96.76%   +0.01%     
==========================================
  Files          52       53       +1     
  Lines        2462     2472      +10     
  Branches      370      370              
==========================================
+ Hits         2382     2392      +10     
  Misses         40       40              
  Partials       40       40

Impacted Files	Coverage Δ
packages/eslint-plugin/lib/util.js	97.22% <ø> (ø)	⬆️
...ackages/eslint-plugin/lib/rules/no-for-in-array.js	100% <100%> (ø)

Comments addressed