-
-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(eslint-plugin): add rule no-unsafe-assignment #1694
Conversation
Thanks for the PR, @bradzacher! typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community. The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately. Thanks again! 🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. As a thank you, your profile/company logo will be added to our main README which receives thousands of unique visitors per day. |
ef6a841
to
69ec840
Compare
Codecov Report
@@ Coverage Diff @@
## master #1694 +/- ##
==========================================
- Coverage 94.64% 94.42% -0.23%
==========================================
Files 160 161 +1
Lines 7263 7386 +123
Branches 2081 2117 +36
==========================================
+ Hits 6874 6974 +100
- Misses 167 180 +13
- Partials 222 232 +10
|
Is there anything blocking this? Been trying out the other |
There's nothing blocking it any more. I was going to add an option to prevent "evolving" types, but I decided against that for now (I think it deserves to live as its own rule). With the CI passing, I'll merge this now. |
See: #791, and the other rules I've added #1643, #1644, #1647