-
-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(eslint-plugin): [unbound-method] false positive on property function initializer #1890
fix(eslint-plugin): [unbound-method] false positive on property function initializer #1890
Conversation
Thanks for the PR, @vapurrmaid! typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community. The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately. Thanks again! 🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. As a thank you, your profile/company logo will be added to our main README which receives thousands of unique visitors per day. |
Codecov Report
@@ Coverage Diff @@
## master #1890 +/- ##
==========================================
- Coverage 94.39% 94.38% -0.02%
==========================================
Files 164 164
Lines 7583 7585 +2
Branches 2179 2180 +1
==========================================
+ Hits 7158 7159 +1
- Misses 182 183 +1
Partials 243 243
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
logic itself looks good.
one minor change
thanks for this!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice! thanks for this
Thanks @vapurrmaid! |
resolves #1869