Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(eslint-plugin): add new rule no-require-imports #199

Merged

Conversation

lukyth
Copy link
Contributor

@lukyth lukyth commented Feb 3, 2019

Adds the equivalent of TSLint's no-require-imports rule.

@codecov
Copy link

codecov bot commented Feb 3, 2019

Codecov Report

Merging #199 into master will increase coverage by <.01%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master     #199      +/-   ##
==========================================
+ Coverage   96.78%   96.78%   +<.01%     
==========================================
  Files          55       56       +1     
  Lines        2516     2522       +6     
  Branches      372      372              
==========================================
+ Hits         2435     2441       +6     
  Misses         42       42              
  Partials       39       39
Impacted Files Coverage Δ
...ages/eslint-plugin/lib/rules/no-require-imports.js 100% <100%> (ø)

@lukyth lukyth force-pushed the lukyth/new-rule-no-require-imports branch from 10f3bc8 to 7ea0f4d Compare February 4, 2019 01:49
@lukyth lukyth force-pushed the lukyth/new-rule-no-require-imports branch from 7ea0f4d to 1de278f Compare February 4, 2019 01:54
@lukyth
Copy link
Contributor Author

lukyth commented Feb 4, 2019

@bradzacher Thank you for your review :) I've addressed all the comments. Could you please check it out?

@armano2 armano2 added the enhancement: new plugin rule New rule request for eslint-plugin label Feb 4, 2019
bradzacher
bradzacher previously approved these changes Feb 4, 2019
@j-f1
Copy link
Contributor

j-f1 commented Feb 4, 2019

Just thinking — would this be better suited as a rule in eslint-plugin-import?

@lukyth
Copy link
Contributor Author

lukyth commented Feb 4, 2019

Not sure what's best here. I can try moving this over to eslint-plugin-import if you think it's more appropriate.

@sindresorhus
Copy link

I think the rule should stay here. eslint-plugin-import is not very actively maintained and it also doesn't currently have any rules that target TypeScript.

@JamesHenry
Copy link
Member

Apologies for the conflicts, we decided to remove the counts from the ROADMAP here: #225

They are too awkward to maintain manually, so this is the last time you will have to deal with syncing that up!

@JamesHenry JamesHenry merged commit 683e5bc into typescript-eslint:master Feb 7, 2019
@lukyth lukyth deleted the lukyth/new-rule-no-require-imports branch February 7, 2019 15:52
kaicataldo pushed a commit to kaicataldo/typescript-eslint that referenced this pull request Aug 27, 2019
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 21, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement: new plugin rule New rule request for eslint-plugin
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants