feat(ts-estree): fix issues with typeParams in FunctionExpression #208
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- fix range of FunctionExpression with typeParams - fix regression: move typeParameters from Property back to FunctionExpression
Codecov Report
@@ Coverage Diff @@
## master #208 +/- ##
==========================================
+ Coverage 96.2% 96.21% +<.01%
==========================================
Files 51 51
Lines 2451 2455 +4
Branches 369 370 +1
==========================================
+ Hits 2358 2362 +4
Misses 48 48
Partials 45 45
|
JamesHenry
approved these changes
Feb 4, 2019
kaicataldo
pushed a commit
to kaicataldo/typescript-eslint
that referenced
this pull request
Aug 27, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes: prettier/prettier#5817