Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ts-estree): convert decorators on var and fn decs #211

Merged
merged 3 commits into from
Feb 7, 2019

Conversation

JamesHenry
Copy link
Member

@JamesHenry JamesHenry commented Feb 5, 2019

fixes #185

I've used the same comment we used in other places, such as interfaces and enums

armano2
armano2 previously approved these changes Feb 5, 2019
Copy link
Member

@armano2 armano2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just regenerate tests for parser

@codecov
Copy link

codecov bot commented Feb 7, 2019

Codecov Report

Merging #211 into master will increase coverage by <.01%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master     #211      +/-   ##
==========================================
+ Coverage   96.76%   96.77%   +<.01%     
==========================================
  Files          53       53              
  Lines        2472     2478       +6     
  Branches      370      372       +2     
==========================================
+ Hits         2392     2398       +6     
  Misses         40       40              
  Partials       40       40
Impacted Files Coverage Δ
packages/typescript-estree/src/convert.ts 97.6% <100%> (+0.02%) ⬆️

@JamesHenry JamesHenry merged commit 0a1777f into master Feb 7, 2019
@JamesHenry JamesHenry deleted the dodgy-decorators branch February 7, 2019 02:04
kaicataldo pushed a commit to kaicataldo/typescript-eslint that referenced this pull request Aug 27, 2019
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 21, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Throw errors for non-class decorators
2 participants