fix(eslint-plugin): out-of-bounds access in member-ordering rule #304
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes Cannot read property 'replace' of undefined error when
unknown node types are used in the source code.
Also adds TODO comments for missing node types.
Some background information:
There are several node types that are not implemented yet, like:
In that case, the current implementation returns
Number.MAX_SAFE_INTEGER
to increase the order ranking. IngetLowestRank
, however, this number is used as index fororder
which will obviously fail in some cases.In my case, the
rank
ingetLowestRank
was an array that looked like this[ 3, 3, 16, 9007199254740991 ]
. This threw:Fixes #307