Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The ESM symbol from eslint-utils ReferenceTracker should be typed #3527

Closed
3 tasks done
MageJohn opened this issue Jun 14, 2021 · 1 comment · Fixed by #3532
Closed
3 tasks done

The ESM symbol from eslint-utils ReferenceTracker should be typed #3527

MageJohn opened this issue Jun 14, 2021 · 1 comment · Fixed by #3532
Labels
enhancement New feature or request package: utils Issues related to the @typescript-eslint/utils package

Comments

@MageJohn
Copy link
Contributor

  • I have tried restarting my IDE and the issue persists.
  • I have updated to the latest version of the packages.
  • I have read the FAQ and my problem is not listed.

Repro

import { ASTUtils } from "@typescript-eslint/experimental-utils";
const { ReferenceTracker } = ASTUtils;

const ESM = ReferenceTracker.ESM;

Expected Result

No type errors.

Actual Result

A type error, because there is no ESM key on the exported ReferenceTracker interface from ast-utils.

Additional Info

This seems to be an undocumented export, but you can see it being defined in eslint-utils here. It's apparently used to mark a traceMap as being an ES module.

Versions

package version
@typescript-eslint/experimental-utils 4.26.1
TypeScript 4.3.2
node 12.22.0
@MageJohn MageJohn added package: utils Issues related to the @typescript-eslint/utils package triage Waiting for maintainers to take a look labels Jun 14, 2021
@bradzacher
Copy link
Member

We accept all contributions.
Don't be afraid to raise one to add it!

@bradzacher bradzacher added enhancement New feature or request and removed triage Waiting for maintainers to take a look labels Jun 14, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 18, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request package: utils Issues related to the @typescript-eslint/utils package
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants