feat(ast-spec): bring Node objects in line with ESTree

[MichaelDeBoey]

https://github.com/estree/estree/blob/master/es5.md#node-objects
https://eslint.org/docs/developer-guide/working-with-custom-parsers#the-ast-specification

---

BREAKING CHANGE: LineAndColumnData is renamed to Position

[typescript-eslint]

Thanks for the PR, @MichaelDeBoey!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

---

🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. As a thank you, your profile/company logo will be added to our main README which receives thousands of unique visitors per day.

[nx-cloud]

Nx Cloud Report

CI ran the following commands for commit 275eb0b. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch

Status	Command
	nx test @typescript-eslint/eslint-plugin-tslint
	nx test @typescript-eslint/eslint-plugin
	nx test @typescript-eslint/eslint-plugin-internal
	nx test @typescript-eslint/eslint-plugin-tslint
	nx test @typescript-eslint/eslint-plugin
	nx test @typescript-eslint/eslint-plugin-tslint
	nx test @typescript-eslint/eslint-plugin
	nx test @typescript-eslint/eslint-plugin-tslint
	nx test @typescript-eslint/eslint-plugin
	nx test @typescript-eslint/parser
	nx test @typescript-eslint/experimental-utils
	nx test @typescript-eslint/scope-manager
	nx test @typescript-eslint/parser
	nx test @typescript-eslint/parser
	nx test @typescript-eslint/experimental-utils
	nx test @typescript-eslint/visitor-keys
	nx test @typescript-eslint/scope-manager
	nx test @typescript-eslint/visitor-keys
	nx run-many --target=typecheck --all --parallel
	nx test @typescript-eslint/typescript-estree

---

Sent with 💌 from NxCloud.

[MichaelDeBoey]

@bradzacher The PR as it is right now isn't a breaking change, as we still expose LineAndColumnData.

Was planning on doing a follow-up PR to the v5 branch with removing it, but if you want, I'm happy to rebase this branch onto v5 and make it a breaking change from the start.

[codecov]

Codecov Report

Merging #3771 (8f540b7) into v5 (cbbf22a) will decrease coverage by 0.70%.
The diff coverage is 100.00%.

❗ Current head 8f540b7 differs from pull request most recent head 275eb0b. Consider uploading reports for the commit 275eb0b to get more accurate results

@@            Coverage Diff             @@
##               v5    #3771      +/-   ##
==========================================
- Coverage   93.40%   92.70%   -0.71%     
==========================================
  Files         151      331     +180     
  Lines        8084    11640    +3556     
  Branches     2563     3291     +728     
==========================================
+ Hits         7551    10791    +3240     
- Misses        181      371     +190     
- Partials      352      478     +126     

Flag	Coverage Δ
unittest	92.70% <100.00%> (-0.71%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
...gin-internal/src/rules/no-poorly-typed-ts-props.ts	88.88% <ø> (ø)
...ges/eslint-plugin/src/rules/no-inferrable-types.ts	93.33% <ø> (ø)
...nt-plugin/src/rules/no-unused-vars-experimental.ts	91.39% <ø> (ø)
...ges/scope-manager/src/definition/DefinitionType.ts	100.00% <ø> (ø)
...plugin-internal/src/rules/prefer-ast-types-enum.ts	91.30% <100.00%> (ø)
...plugin/src/rules/explicit-module-boundary-types.ts	89.47% <100.00%> (ø)
...ages/eslint-plugin/src/rules/no-require-imports.ts	100.00% <100.00%> (ø)
packages/eslint-plugin/src/rules/no-shadow.ts	77.34% <100.00%> (+0.73%)	⬆️
packages/eslint-plugin/src/rules/no-type-alias.ts	100.00% <100.00%> (ø)
...es/eslint-plugin/src/rules/no-use-before-define.ts	91.20% <100.00%> (+0.09%)	⬆️
... and 293 more

[bradzacher]

let's just target this at v5 and avoid the interim migration step.
i'm happy to merge this in.

[MichaelDeBoey]

@bradzacher Do I remove the LineAndColumnData type then?

[bradzacher]

Yup! Remove it and rebase on the v5 branch

[MichaelDeBoey]

@bradzacher It should be good to go now 🙂

[bradzacher]

thanks!