Bug: NewExpression doesn't allow SpreadElement as argument

[burtek]

Before You File a Proposal Please Confirm You Have Done The Following...

• I have searched for related issues and found none that match my proposal.
• I have searched the current rule list and found no rules that match my proposal.
• I have read the FAQ and my problem is not listed.

Relevant Package

ast-spec

My proposal is suitable for this project

• I believe my proposal would be useful to the broader TypeScript community (meaning it is not a niche proposal).

Description

NewExpression and CallExpression are basically identical in terms of arguments list. Among others, you're perfectly fine with spreading arguments in both of them:

class A { constructor(...args: unknown[]) {} }
const a = new A(...someArray);

const F = (...args: unknown[]) => {}
const f = F(...someArray);

That is reflected in CallExpression type:

typescript-eslint/packages/ast-spec/src/expression/CallExpression/spec.ts

Lines 7 to 10 in d2394f8

	export interface CallExpression extends BaseNode {
	type: AST_NODE_TYPES.CallExpression;
	callee: LeftHandSideExpression;
	arguments: CallExpressionArgument[];

With CallExpressionArgument being:

typescript-eslint/packages/ast-spec/src/unions/CallExpressionArgument.ts

Line 4 in d2394f8

export type CallExpressionArgument = Expression | SpreadElement;

At the same time, NewExpression typing allows only Expression arguments:

typescript-eslint/packages/ast-spec/src/expression/NewExpression/spec.ts

Lines 7 to 10 in d2394f8

	export interface NewExpression extends BaseNode {
	type: AST_NODE_TYPES.NewExpression;
	callee: LeftHandSideExpression;
	arguments: Expression[];

SpreadElement is not there, even though it is legal to spread arguments in constructor call (playground)

Fail

n/a

Pass

n/a

Additional Info

No response

[burtek]

Ofc happy to preapre a PR for this, but as this is my first contribution to typescript-eslint, I wanted to make sure this is discussed and that my thinking is correct

[bradzacher]

This is definitely a bug in the types NewExpression should accept the same argument type as CallExpression!

[burtek]

Working on it :)