Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: bump minimum supported TS version to 4.2.4 #5915

Merged
merged 4 commits into from Nov 7, 2022
Merged

Conversation

bradzacher
Copy link
Member

@bradzacher bradzacher commented Nov 2, 2022

BREAKING CHANGE:
Bumps the minimum supported range and removes handling for old versions

PR Checklist

Overview

DT hasn't bumped to 4.2 yet, but it's only just ticked to november, so I'd expect them to do it soon - likely before we do the major release.

This PR:

  • updates docs to clarify our version support windows
  • bumps the ranges around the place
  • removes no-longer-necessary checks for now outdated versions

BREAKING CHANGE:
Bumps the minimum supported range and removes handling for old versions.

Ref #1752
@bradzacher bradzacher added enhancement New feature or request breaking change This change will require a new major version to be released labels Nov 2, 2022
@typescript-eslint
Copy link
Contributor

Thanks for the PR, @bradzacher!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!


🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint.

@nx-cloud
Copy link

nx-cloud bot commented Nov 2, 2022

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 0c29c34. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch


✅ Successfully ran 46 targets

Sent with 💌 from NxCloud.

@codecov
Copy link

codecov bot commented Nov 2, 2022

Codecov Report

Merging #5915 (0c29c34) into v6 (9b5fa0b) will increase coverage by 0.25%.
The diff coverage is 100.00%.

Additional details and impacted files
@@            Coverage Diff             @@
##               v6    #5915      +/-   ##
==========================================
+ Coverage   91.44%   91.69%   +0.25%     
==========================================
  Files         355      355              
  Lines       12058    12009      -49     
  Branches     3530     3518      -12     
==========================================
- Hits        11026    11012      -14     
+ Misses        733      701      -32     
+ Partials      299      296       -3     
Flag Coverage Δ
unittest 91.69% <100.00%> (+0.25%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
packages/typescript-estree/src/version-check.ts 100.00% <ø> (ø)
...n/src/rules/no-non-null-asserted-optional-chain.ts 100.00% <100.00%> (+53.33%) ⬆️
...plugin/src/rules/no-unnecessary-type-constraint.ts 100.00% <100.00%> (+12.00%) ⬆️
packages/typescript-estree/src/convert.ts 97.85% <100.00%> (+0.25%) ⬆️
...pt-estree/src/create-program/createWatchProgram.ts 83.79% <100.00%> (+5.73%) ⬆️
...ipt-estree/src/parseSettings/warnAboutTSVersion.ts 93.33% <100.00%> (ø)

- We _generally_ do not officially support the `rc` releases.
- We endeavour to support the latest stable TypeScript versions as soon as possible after the release.

Generally we will begin working on supporting the next release when the `rc` version is released.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this decision documented anywhere? Now that we have more maintainer funding & people, it'd be nice to be able to support RC releases. But that's really hard and I'm guessing still not something worth it.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm all for us bumping versions and allowing RCs if we're able to - I just don't want us to set the expectation that we will support all RCs.

Sometimes releases are massive and and can take a lot of work to fully support.
Sometimes they have literally no impact for us.
Sometimes features from the beta get dropped from the RC.
Sometimes features from the RC get dropped from the full release.

There's just a lot of variability and with our limited bandwidth I don't want us to commit to anything!

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member

@JoshuaKGoldberg JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love to see all this code removal! Once the lints are fixed, 🚀

Copy link
Member

@JamesHenry JamesHenry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Beautiful!

README.md Outdated Show resolved Hide resolved
@bradzacher bradzacher merged commit f66a15b into v6 Nov 7, 2022
@bradzacher bradzacher deleted the bump-min-ts-version branch November 7, 2022 01:46
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 17, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
breaking change This change will require a new major version to be released enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants