Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Repo: Source maps don't connect for ast-spec fixtures.test.ts #6116

Open
JoshuaKGoldberg opened this issue Nov 28, 2022 · 0 comments
Open

Repo: Source maps don't connect for ast-spec fixtures.test.ts #6116

JoshuaKGoldberg opened this issue Nov 28, 2022 · 0 comments
Labels
accepting prs Go ahead, send a pull request that resolves this issue repo maintenance things to do with maintenance of the repo, and not with code/docs

Comments

@JoshuaKGoldberg
Copy link
Member

Suggestion

From #5926 (comment):

I'm confused why codecov thinks this isn't covered by tests. I can debug it locally to see the TSAbstractAccessorProperty and AccessorProperty cases being hit. Though, sourcemaps seem to not be working - maybe that's the issue?

Screenshot of debugging in VS Code, on a breakpoint in the `const result` variable below. A watch view shows type to be 'TSAbstractAccessorProperty'.

Steps to reproduce:

  1. Add a breakpoint in packages/typescript-estree/src/convert.ts
  2. Open a JavaScript Debug Terminal
  3. cd packages/ast-spec
  4. yarn jest fixtures

The breakpoint will switch to convert.js.
@JoshuaKGoldberg JoshuaKGoldberg added triage Waiting for maintainers to take a look repo maintenance things to do with maintenance of the repo, and not with code/docs accepting prs Go ahead, send a pull request that resolves this issue and removed triage Waiting for maintainers to take a look labels Nov 28, 2022
@JoshuaKGoldberg JoshuaKGoldberg mentioned this issue Nov 28, 2022
Merged
3 tasks
@JoshuaKGoldberg JoshuaKGoldberg mentioned this issue Dec 24, 2022
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
accepting prs Go ahead, send a pull request that resolves this issue repo maintenance things to do with maintenance of the repo, and not with code/docs
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@JoshuaKGoldberg