Repo: improved management of extension rules #6456
Labels
accepting prs
Go ahead, send a pull request that resolves this issue
enhancement
New feature or request
repo maintenance
things to do with maintenance of the repo, and not with code/docs
Suggestion
Forks
Cons:
Pros:
Overrides
Cons:
Pros:
Originally we tried to do an override wherever possible to save maintenance burden. However we've found over time that we're tightly relying on ESLint's implementations - which can be pretty brittle and can require some hacks to maintain. Some rules required forking because our changes needed access to internal rule logic.
This means that currently our extension rules are a mixed bag - some of them are complete forks, others are slightly hacky overrides. As shown above; neither option is fantastic, but having both also is an even worse state to be in I think.
I propose that we standardise our approach on full forks. Whilst there is more code in our repo - it does mean that we can better manage our code and do fewer hacks.
This ofc does bring in the problem of us needing to watch ESLint releases very closely - however I think we can probably automate this with an action that does the following:
There'd still be the manual effort of actioning this issue - but at least we won't miss anything like we have in the past (eg #4910)
The text was updated successfully, but these errors were encountered: