-
-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(type-utils): file variant of TypeOrValueSpecifier uses canonical filenames instead of lowercasing #6781
fix(type-utils): file variant of TypeOrValueSpecifier uses canonical filenames instead of lowercasing #6781
Conversation
…filenames instead of lowercasing
Thanks for the PR, @marekdedic! typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community. The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately. Thanks again! 🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. |
❌ Deploy Preview for typescript-eslint failed.
|
Hi, |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## v6 #6781 +/- ##
==========================================
- Coverage 87.75% 87.50% -0.25%
==========================================
Files 372 376 +4
Lines 12813 12938 +125
Branches 3800 3821 +21
==========================================
+ Hits 11244 11322 +78
- Misses 1193 1231 +38
- Partials 376 385 +9
Flags with carried forward coverage won't be shown. Click here to find out more.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah I think this is very reasonable 👍. Just, it needs some test coverage please?
Well, I added a test for the normalization, however, I can't really test for capitalization - the test would then fail on some platforms, right? Does it pass on your machine? |
@@ -1,3 +1,4 @@ | |||
import { getCanonicalFileName } from '@typescript-eslint/typescript-estree'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@bradzacher just confirming on architecture things - is there a better dependency setup we can use here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No this is probably the best way to do it and ensures we keep things in sync with the parser's logic.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah I see what you mean - testing this is hard. But what's here so far looks good to me, thanks!
Since this exports a previously internal helper I'll defer to its author for a second review.
PR Checklist