range and loc options are always true

[ehmicky]

What code were you trying to parse?

typescriptEstree.parse('true', {range: false, loc: false})

What did you expect to happen?

The returned node should not include the range or loc properties.

What actually happened?

{
  "type": "Program",
  "body": [
    {
      "type": "ExpressionStatement",
      "expression": {
        "type": "Literal",
        "value": true,
        "raw": "true",
        "range": [
          0,
          4
        ],
        "loc": {
          "start": {
            "line": 1,
            "column": 0
          },
          "end": {
            "line": 1,
            "column": 4
          }
        }
      },
      "range": [
        0,
        4
      ],
      "loc": {
        "start": {
          "line": 1,
          "column": 0
        },
        "end": {
          "line": 1,
          "column": 4
        }
      }
    }
  ],
  "sourceType": "script",
  "range": [
    0,
    4
  ],
  "loc": {
    "start": {
      "line": 1,
      "column": 0
    },
    "end": {
      "line": 1,
      "column": 4
    }
  }
}

Versions

package	version
@typescript-eslint/typescript-estree	1.11.0
TypeScript	3.5.3
node	12.6.0
npm	6.10.0

[Mark1626]

Hi @bradzacher,
Can I pick this up? Had a look into the code, I thought of this approach can you comment on it.

I'll update the ConverterOptions to include the range and loc options.

typescript-eslint/packages/typescript-estree/src/convert.ts

Lines 25 to 29 in c2ad091

	interface ConverterOptions {
	errorOnUnknownASTType: boolean;
	useJSXTextNode: boolean;
	shouldPreserveNodeMaps: boolean;
	}

Will then pass the options to convertor instance here

typescript-eslint/packages/typescript-estree/src/ast-converter.ts

Lines 23 to 27 in c2ad091

	const instance = new Converter(ast, {
	errorOnUnknownASTType: extra.errorOnUnknownASTType || false,
	useJSXTextNode: extra.useJSXTextNode || false,
	shouldPreserveNodeMaps,
	});

Then using the options I exclude range and loc from getting added when converting nodes in convert.ts

[ehmicky]

Thanks for working on this! :)