fix(eslint-plugin): [no-confusing-void-expression] handle unfixable cases

[yeonjuan]

PR Checklist

• Addresses an existing open issue: fixes Bug: [no-confusing-void-expression] Wrong autofix for a ? void : T #6187
• That issue was marked as accepting prs
• Steps in Contributing were taken

Overview

This change will prevent autofixes in certain cases. Before the change, it worked like this

  const f = function () {
          let num = 1;
          return num ? console.log('foo') : num;
  };

// after fix
  const f = function () {
          let num = 1;
          num ? console.log('foo') : num;
  };

I changed to not apply fix to node which can be conditionally void.

let num = 1;
const foo = () => num ? console.log('foo') : num;

const f = function () {
     let num = 1;
     return num ? console.log('foo') : num;
};

[typescript-eslint]

Thanks for the PR, @yeonjuan!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

---

🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint.

[netlify]

✅ Deploy Preview for typescript-eslint ready!

Name	Link
🔨 Latest commit	71f9ef4
🔍 Latest deploy log	https://app.netlify.com/sites/typescript-eslint/deploys/652c029ef3b5380008d16691
😎 Deploy Preview	https://deploy-preview-7674--typescript-eslint.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.
Lighthouse	1 paths audited Performance: 89 (🔴 down 7 from production) Accessibility: 100 (no change from production) Best Practices: 92 (no change from production) SEO: 98 (no change from production) PWA: 80 (no change from production) View the detailed breakdown and full score reports

---

To edit notification comments on pull requests, go to your Netlify site configuration.

[nx-cloud]

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 71f9ef4. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution

---

✅ Successfully ran 19 targets

• nx test eslint-plugin --coverage=false
• nx test rule-schema-to-typescript-types --coverage=false
• nx run types:build
• nx test ast-spec --coverage=false
• nx test visitor-keys --coverage=false
• nx test utils --coverage=false
• nx test repo-tools --coverage=false
• nx test parser --coverage=false
• nx test eslint-plugin-tslint --coverage=false
• nx test scope-manager --coverage=false
• nx test typescript-estree --coverage=false
• nx test type-utils --coverage=false
• nx run repo-tools:postinstall-script
• nx test eslint-plugin-internal --coverage=false
• nx run-many --target=typecheck --parallel
• nx run-many --target=lint --parallel
• nx run integration-tests:test
• nx run eslint-plugin:generate:configs
• nx run-many --target=build --parallel --exclude=website --exclude=website-eslint

---

Sent with 💌 from NxCloud.

[JoshuaKGoldberg]

Great - nice spot on checking ts.TypeFlags.VoidLike! This function works perfectly but just has a bit of dead code I think. Requesting changes just on that.

Super thorough tests, too! 👏

[JoshuaKGoldberg]

Swell, thanks!