fix(typescript-estree): ensure backwards compat with pre-5.3 import attributes #7967
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
TSAssertEntry
#7960Overview
We don't have old TS version regression tests so this is a bit of a "trust me bro".
Manual test steps:
yarn && yarn build
packages/typescript-estree/dist
yarn add @typescript-eslint/typescript-estree
node
and use the repl from the issue (require('@typescript-eslint/typescript-estree').parse('import json from "./foo.json" assert { type: "json", type: "bar" };').body[0].attributes
) --> observe the broken AST is printed.node_modules/@typescript-eslint/typescript-estree/
node
and use the repl from the issue --> observe the correct AST is printed.