Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(eslint-plugin): [explicit-function-return-type] add support for typed class property definitions #8027

Merged
merged 1 commit into from Dec 5, 2023

Conversation

auvred
Copy link
Member

@auvred auvred commented Dec 5, 2023

PR Checklist

Overview

Check also the PropertyDefinition nodes, not just the VariableDeclarator

@typescript-eslint
Copy link
Contributor

Thanks for the PR, @auvred!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!


🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint.

Copy link

netlify bot commented Dec 5, 2023

Deploy Preview for typescript-eslint failed.

Name Link
🔨 Latest commit f59ff25
🔍 Latest deploy log https://app.netlify.com/sites/typescript-eslint/deploys/656f5e1d9c6d220008ed0ddf

Copy link
Member

@JoshuaKGoldberg JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯 great, thanks! A nice clean solution.

Claymation sheep giving two thumbs up

@JoshuaKGoldberg JoshuaKGoldberg merged commit bff47d7 into typescript-eslint:main Dec 5, 2023
54 of 58 checks passed
@AndreasHae
Copy link

@auvred @JoshuaKGoldberg wow, I'm amazed by the speed with which this got fixed. Thank you guys!

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 15, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
3 participants