Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug: [require-array-sort-compare] Does not work with Array.toSorted #8051

Closed
4 tasks done
Zamiell opened this issue Dec 12, 2023 · 0 comments · Fixed by #8052
Closed
4 tasks done

Bug: [require-array-sort-compare] Does not work with Array.toSorted #8051

Zamiell opened this issue Dec 12, 2023 · 0 comments · Fixed by #8052
Labels
accepting prs Go ahead, send a pull request that resolves this issue bug Something isn't working package: eslint-plugin Issues related to @typescript-eslint/eslint-plugin

Comments

@Zamiell
Copy link
Contributor

Zamiell commented Dec 12, 2023 •
edited

Before You File a Bug Report Please Confirm You Have Done The Following...

  • I have tried restarting my IDE and the issue persists.
  • I have updated to the latest version of the packages.
  • I have searched for related issues and found none that matched my issue.
  • I have read the FAQ and my problem is not listed.

Playground Link

https://typescript-eslint.io/play/#ts=5.3.2&fileType=.tsx&code=MYewdgzgLgBAZiEMC8MDaBGANDATDgZgF0BuAWAChKEQA6CEAJygAoBKcim2qEAZSZQApgBN2nIA&eslintrc=N4KABGBEBOCuA2BTAzpAXGUEKQAIBcBPABxQGNoBLY-AWhXkoDt8B6aRAR1ko9oENo0foVrIA9tDplxAW2KDE6KIiGTI4MAF8QOoA&tsconfig=N4KABGBEDGD2C2AHAlgGwKYCcDyiAuysAdgM6QBcYoEEkJemy0eAcgK6qoDCAFutAGsylBm3TgwAXxCSgA&tokens=false

Repro Code

const foo = [1, 2, 3];

foo.sort(); // Error, works as expected
foo.toSorted(); // No error, but should be an error
@Zamiell Zamiell added bug Something isn't working package: eslint-plugin Issues related to @typescript-eslint/eslint-plugin triage Waiting for maintainers to take a look labels Dec 12, 2023
@Zamiell Zamiell mentioned this issue Dec 12, 2023
Merged
3 tasks
@bradzacher bradzacher added accepting prs Go ahead, send a pull request that resolves this issue and removed triage Waiting for maintainers to take a look labels Dec 12, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 20, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
accepting prs Go ahead, send a pull request that resolves this issue bug Something isn't working package: eslint-plugin Issues related to @typescript-eslint/eslint-plugin
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: require-array-sort-compare + toSorted Zamiell/typescript-eslint
2 participants
@Zamiell @bradzacher