Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: [prefer-readonly] prefer-readonly should not consider accessors #8299

Closed
4 tasks done
Jamesernator opened this issue Jan 25, 2024 · 0 comments · Fixed by #8300
Closed
4 tasks done

Bug: [prefer-readonly] prefer-readonly should not consider accessors #8299

Jamesernator opened this issue Jan 25, 2024 · 0 comments · Fixed by #8300
Labels
accepting prs Go ahead, send a pull request that resolves this issue bug Something isn't working package: eslint-plugin Issues related to @typescript-eslint/eslint-plugin

Comments

@Jamesernator
Copy link
Contributor

Jamesernator commented Jan 25, 2024

Before You File a Bug Report Please Confirm You Have Done The Following...

  • I have tried restarting my IDE and the issue persists.
  • I have updated to the latest version of the packages.
  • I have searched for related issues and found none that matched my issue.
  • I have read the FAQ and my problem is not listed.

Playground Link

https://typescript-eslint.io/play/#ts=5.3.3&fileType=.tsx&code=FAYwNghgzlAEBiB7RsDexawA4CcCWAbhAC4CmsEIIpMiOFVsAvLAMwDcwGD1t9AxJRDNYAFk4BfIA&eslintrc=N4KABGBEBOCuA2BTAzpAXGUEKQAIBcBPABxQGNoBLY-AWhXkoDt8B6Y6RAM0Wls4CGAEwD2TeIXRRe0EdEjgwAXxBKgA&tsconfig=N4KABGBEDGD2C2AHAlgGwKYCcDyiAuysAdgM6QBcYoEEkJemy0eAcgK6qoDCAFutAGsylBm3TgwAXxCSgA&tokens=false

Repro Code

class Foo {
  private accessor acc = 3;

  accessor #acc = 4;
}

ESLint Config

module.exports = {
  "rules": {
    "@typescript-eslint/prefer-readonly": "error"
  }
};

tsconfig

{
  "compilerOptions": {
    "strictNullChecks": true
  }
}

Expected Result

Accessors should be ignored by prefer-readonly as they cannot be marked as readonly.

Actual Result

A broken fix is done that adds readonly to the accessors:

class Foo {
  private accessor readonly acc = 3;

  accessor readonly #acc = 4;
}

Additional Info

I will make a PR for this.

@Jamesernator Jamesernator added bug Something isn't working package: eslint-plugin Issues related to @typescript-eslint/eslint-plugin triage Waiting for maintainers to take a look labels Jan 25, 2024
@JoshuaKGoldberg JoshuaKGoldberg added accepting prs Go ahead, send a pull request that resolves this issue and removed triage Waiting for maintainers to take a look labels Jan 28, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 6, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
accepting prs Go ahead, send a pull request that resolves this issue bug Something isn't working package: eslint-plugin Issues related to @typescript-eslint/eslint-plugin
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants