Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(parser): support ecmaFeatures.jsx flag and tests #85

Merged
merged 3 commits into from
Jan 20, 2019
Merged

feat(parser): support ecmaFeatures.jsx flag and tests #85

merged 3 commits into from
Jan 20, 2019

Conversation

armano2
Copy link
Member

@armano2 armano2 commented Jan 20, 2019

This PR contains changes from eslint/typescript-eslint-parser#595 with small refactor propagating options

fixes: eslint/typescript-eslint-parser#594
fixes: #24

@armano2 armano2 requested review from bradzacher and a team and removed request for bradzacher January 20, 2019 01:58
@codecov
Copy link

codecov bot commented Jan 20, 2019

Codecov Report

Merging #85 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #85      +/-   ##
==========================================
+ Coverage    94.8%   94.81%   +<.01%     
==========================================
  Files          48       48              
  Lines        2465     2469       +4     
  Branches      380      381       +1     
==========================================
+ Hits         2337     2341       +4     
  Misses         77       77              
  Partials       51       51
Impacted Files Coverage Δ
packages/parser/src/parser.ts 100% <100%> (ø) ⬆️
packages/typescript-estree/src/parser.ts 78.3% <100%> (-0.21%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cbb7ffe...1fe34b0. Read the comment docs.

@armano2
Copy link
Member Author

armano2 commented Jan 20, 2019

should we warn users when options passed to parser are invalid?

@armano2 armano2 changed the title feat(parser): validate options passed to parser feat(parser): support ecmaFeatures.jsx flag and tests Jan 20, 2019
@JamesHenry JamesHenry merged commit b321736 into typescript-eslint:master Jan 20, 2019
@armano2 armano2 deleted the parser-options branch January 20, 2019 14:30
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 21, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
2 participants