docs: [no-wrapper-object-types] clean up a bit of phrasing

[kirkwaiblinger]

PR Checklist

• Addresses an existing open issue: fixes #000 followup to https://github.com/typescript-eslint/typescript-eslint/pull/9102/files/f25f33396926cf0bb03eac1d02d8636987d3ec28..e078105858728c2cfe6bdf81a145feae291cb43c#r1635229512
• That issue was marked as accepting prs
• Steps in Contributing were taken

Overview

[typescript-eslint]

Thanks for the PR, @kirkwaiblinger!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

---

🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint.

[netlify]

✅ Deploy Preview for typescript-eslint ready!

Name	Link
🔨 Latest commit	3821222
🔍 Latest deploy log	https://app.netlify.com/sites/typescript-eslint/deploys/667742c4100aed0009bd69b4
😎 Deploy Preview	https://deploy-preview-9363--typescript-eslint.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.
Lighthouse	1 paths audited Performance: 99 (🟢 up 1 from production) Accessibility: 100 (no change from production) Best Practices: 92 (no change from production) SEO: 90 (no change from production) PWA: 80 (no change from production) View the detailed breakdown and full score reports

---

To edit notification comments on pull requests, go to your Netlify site configuration.

[kirkwaiblinger]

made slight edit here to try to clarify that it's about the runtime typeof operator in TS vs the type-time typeof operator, which also exists.

[nx-cloud]

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 3821222. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution

---

✅ Successfully ran 32 targets

• nx test eslint-plugin --coverage=false
• nx run-many --target=test --parallel --exclude integration-tests --exclude website --exclude website-eslint
• nx test eslint-plugin
• nx test typescript-estree --coverage=false
• nx test typescript-eslint --coverage=false
• nx test scope-manager --coverage=false
• nx test type-utils --coverage=false
• nx run types:build
• nx test utils --coverage=false
• nx test visitor-keys --coverage=false
• nx test parser --coverage=false
• nx test rule-schema-to-typescript-types --coverage=false
• nx run repo-tools:postinstall-script
• nx test eslint-plugin-internal --coverage=false
• nx test repo-tools --coverage=false
• nx run-many --target=build --parallel --exclude=website --exclude=website-eslint
• nx test ast-spec --coverage=false
• nx run-many --target=lint --parallel --exclude eslint-plugin
• nx test typescript-estree
• nx test utils
• nx test type-utils
• nx test visitor-keys
• nx test ast-spec
• nx test scope-manager
• nx test typescript-eslint
• nx test eslint-plugin-internal
• nx test parser
• nx test rule-schema-to-typescript-types
• nx test repo-tools
• nx run integration-tests:test
• nx run-many --target=typecheck --parallel
• nx run repo-tools:generate-configs

---

Sent with 💌 from NxCloud.

[JoshuaKGoldberg]

🙌 lovely!

[Josh-Cena]

Suggested change

	It is widely considered a JavaScript best practice to work directly with the built-in primitives, like `0`, rather than objects that "look like" numbers, like `new Number(0)`.
	Primitives are simpler to conceptualize, work with `==` and `===` equality checks -- which their object equivalents do notDeepEqual -- and have well-known behavior around truthiness/falsiness which is common to rely on.
	It is widely considered a JavaScript best practice to work directly with the built-in primitives, like `0`, rather than objects that "look like" numbers, like `new Number(0)`.
	Primitives work with `==` and `===` equality checks and have more commonly relied-on behavior around truthiness/falsiness, while two objects that wrap the same primitive values do not compare equal, and _all_ wrapper objects are truthy regardless of the wrapped value.
	Furthermore TypeScript prevents using `Number` in places that expect `number`—if a function accepts `number`, you cannot pass a value of type `Number` to it.
	You also cannot do subtraction on `Number` values.

[kirkwaiblinger]

I'll think about this a bit. Two things I wanna pay attention to

1. number is the specific example in this section, but it's supposed to make a point about the primitives in general, not just numbers
2. If we give too much justification, it can seem like this is something controversial that we're just weirdly strongly opinionated about, rather than something that's not even slightly in dispute by anyone. 😆

[Josh-Cena]

That's true. Well it's up to your decision. I certainly want to keep this phrasing though:

Primitives work with == and === equality checks and have more commonly relied-on behavior around truthiness/falsiness, while two objects that wrap the same primitive values do not compare equal, and all wrapper objects are truthy regardless of the wrapped value.

[kirkwaiblinger]

Adapted this a bit to make space for examples, each using a different primitive type. Let me know what you think!

[JoshuaKGoldberg]

While we're here 😄 I'm re-reading this and finding it hard to parse... maybe:

Suggested change

	The JavaScript language has a set of language types, but some of them correspond to two TypeScript types, which look similar: `boolean`/`Boolean`, `number`/`Number`, `string`/`String`, `bigint`/`BigInt`, `symbol`/`Symbol`, `object`/`Object`.
	The JavaScript language has a set of built-in ("intrinsic") type pairs which look similar: `boolean`/`Boolean`, `number`/`Number`, `string`/`String`, `bigint`/`BigInt`, `symbol`/`Symbol`, and `object`/`Object`.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.42%. Comparing base (5cd80ca) to head (3821222).
Report is 3 commits behind head on v8.

Additional details and impacted files

@@            Coverage Diff             @@
##               v8    #9363      +/-   ##
==========================================
+ Coverage   87.39%   87.42%   +0.03%     
==========================================
  Files         390      390              
  Lines       13218    13245      +27     
  Branches     3829     3833       +4     
==========================================
+ Hits        11552    11580      +28     
+ Misses       1364     1363       -1     
  Partials      302      302              

Flag	Coverage Δ
unittest	87.42% <ø> (+0.03%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 2 files with indirect coverage changes

[JoshuaKGoldberg]

Yay!