fix: handle shutdown lifecycle properly #536
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove forced process exit from mocha configuration (which was a way to workaround the issue with the server process not being explicitly shut down) and make sure the tsserver client and the lsp server are destroyed properly.
This can also affect non-test use-cases but hopefully not for the worse.
The issue with the original problem was that:
a) the server didn't cleanly shut itself down
b) whenever the tsserver was closed (either due to
shutdowncall or just crashed) the code would also force-exit the LS server process. This was typically OK but it wasn't clean and could be problematic for those who'd want to use the server programmatically and not force-close their process when server closes.