fix: declare quickfix/refactor CodeAction capabilities #553
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CGNonofr
changed the title
rchl
approved these changes
Aug 3, 2022
rchl
changed the title
|
thanks |
rchl
added a commit
that referenced
this pull request
Aug 3, 2022
* master: fix: declare quickfix/refactor CodeAction capabilities (#553)
|
Thanks for your reactivity! Will a new release be created? |
|
On unrelated note, I wonder if your use case is using this programmatically or are you communicating with it through I have some changes at #547 that can affect projects that use this server programmatically and I wonder about potential issues with that. |
I'm planning to introduce that mentioned PR before making a new release. |
|
I'm using it through stdin/out, it won't be a problem for me ! |
rchl
pushed a commit
that referenced
this pull request
Aug 6, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a bug in monaco-languageclient, (droping codeAction provider metadata), which was making this issue invisible.
The issue is now fixed and quickfix code actions are not working anymore with this LSP implementation because it doesn't declare the quickfix codeAction capability, even though it's able to handle them.