feat: support textDocument/inlayHint request from 3.17.0 spec
#566
Conversation
| return []; | ||
| } | ||
|
|
||
| if (!areInlayHintsEnabledForFile(configurationManager, file)) { |
There was a problem hiding this comment.
is this check necessary?
There was a problem hiding this comment.
Yes. Otherwise, even with all inlay hint options disabled, the server would still do expensive processing that takes a significant amount of time. The old implementation suffered from that which I've realized when working on this.
|
Initial testing show that this works ✔️ 👍 Do you see a need to add a check to respect client capabilities if the client supports inlayHints? (IMO I do not see a need for this check, because the client will not send a inlayHints request in the first place if it doesn't support it) |
No, I don't see the point. Would only be needed if the server would be the initiating side IMO. |
No description provided.