feat: support communicating with tsserver using IPC #585
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I love the idea here! Anything others can do to help? |
| } | ||
|
|
||
| export const nodeRequestCancellerFactory = new class implements OngoingRequestCancellerFactory { | ||
| create(/*serverId: string, tracer: Tracer*/): OngoingRequestCanceller { |
There was a problem hiding this comment.
should /*serverId: string */ be commented out?
There was a problem hiding this comment.
It should as it's not used currently. But forgot to comment out in the interfaces also.
There was a problem hiding this comment.
It looks like serverId is not necessary or used in NodeRequestCanceller,
but it just looked strange to see serverId being commented out only for this method.
| import { NodeTsServerProcessFactory } from './serverProcess.js'; | ||
| import type { TypeScriptVersion } from './versionProvider.js'; | ||
|
|
||
| export class TypeScriptServerSpawner { |
There was a problem hiding this comment.
Is it maybe planned to have multiple processes for each TsServerProcessKind?
export const enum TsServerProcessKind {
Main = 'main',
Syntax = 'syntax',
Semantic = 'semantic',
Diagnostics = 'diagnostics'
}
There was a problem hiding this comment.
Not sure if multiple for each but I don't think so...
It would be one of each at most, I imagine.
rchl
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ported a bunch of code from "VSCode typescript features" to enable us to be able to communicate with
tsserverover IPC instead ofstdio. IPC is used for tsserver (typescript) versions 4.60+, otherwise the legacy stdio is used.If this seems like a lot of code to handle that case then yes, it is, but it's part of the plan to align the code as closely as possible with VSCode to be able to support features like #358 without re-inventing the wheel.