fix(completions): remove filterText override for bracket accessor #593
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rchl
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removed this old code that overridden filterText for bracket accessor completions.
This old code originally came from VSCode and was later replaced there with a quite different code: microsoft/vscode@beb5998 to fix issue microsoft/vscode#63100
I've tested in ST and don't see the issue that VSCode had so given no evidence that it's needed outside of VSCode, I'm not trying to replicate what they did here.
Also, in ST at least, the results are better without this old code:
Before:
After:
So before this change editor has shown a leading dot which is not really needed or expected.
As a bonus (in ST at least) it makes this case better as we can see that the property is optional: