fix(completions): don't create snippet kind without completeFunctionCalls

[rchl]

Server was supposed to create snippet completions on "resolve" for method and function completion kinds when the completeFunctionCalls workspace settings was enabled.

The code that has created the snippet during "resolve" was checking before-mentioned option but the code that initially set the insertTextFormat to Snippet did not. That meant that with completeFunctionCalls disabled, the method and function completions were set to Snippet kind initially but without a chance of being changed to actual snippets during "resolve".

And for editors that can't use resolved values that meant that those would potentially receive completions with unescaped $ character in them while not actually being actual snippet.

[predragnikolic]

Suggested change

	return options.completeFunctionCalls === true && (kind === lsp.CompletionItemKind.Function || kind === lsp.CompletionItemKind.Method);
	return options.completeFunctionCalls && (kind === lsp.CompletionItemKind.Function || kind === lsp.CompletionItemKind.Method);

[rchl]

That would cause type error as options.completeFunctionCalls can be undefined and the function returns boolean.

[predragnikolic]

I can confirm that previously when having:

class A{
	$hello() {}
}

let a = new A()

a.| // try to select $hello in the autcomplete popup will result in not inserting anything in the document. (tested in Sublime Text)

after this change, it results in a.$hello being inserted. (completions.completeFunctionCalls is false)

I also set completions.completeFunctionCalls to true and it behaves as described in the comment.