Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: loading progress sometimes getting stuck #603

Merged
merged 1 commit into from
Oct 9, 2022
Merged

fix: loading progress sometimes getting stuck #603

merged 1 commit into from
Oct 9, 2022

Conversation

rchl
Copy link
Member

@rchl rchl commented Oct 9, 2022

Since the startedLoadingProject method was not awaited, it could happen that finishedLoadingProject would be called before _progressReporter was created on calling startedLoadingProject and it would not cancel the progress that is yet to be created.

startedLoadingProject can not be awaited as it's called from tsevent handler so use promises instead.

@rchl rchl merged commit 8cf4381 into master Oct 9, 2022
@rchl rchl deleted the fix/reporter branch October 9, 2022 20:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant