feat: support workspace/willRenameFiles request
#685
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rchl
reviewed
Feb 11, 2023
rchl
reviewed
Feb 11, 2023
antosha417
requested review from
rchl and
predragnikolic
and removed request for
rchl and
predragnikolic
rchl
approved these changes
Feb 12, 2023
predragnikolic
approved these changes
Feb 12, 2023
Co-authored-by: Предраг Николић <mail@predrag.pro>
rchl
changed the title
workspace/willRenameFiles request
|
Thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey! I've been working on a plugin for neovim that automatically applies workspace edits before moving files around. And it does not work with typescript. The problem with
_typescript.applyRenameFilethat edit is applied only after neovim moves the file.So I wanted to implement
workspase/willRenameFilecommand that returns the edit. We will be then able to preview and apply it if needed.Closes #665
Closes antosha417/nvim-lsp-file-operations#6