feat: start separate tsServer instance for semantic requests #688
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rchl
changed the title
rchl
commented
Feb 15, 2023
| * | ||
| * @default 'auto' | ||
| */ | ||
| useSyntaxServer?: 'auto' | 'never'; |
There was a problem hiding this comment.
It looks like it should be a boolean value but it's this way because VSCode also supports always and I want to have this future-proof in case support for always is added later.
To support always we'd need to add a bunch of checks to avoid triggering certain requests when it's used. Also, I believe that in VSCode the always value is forced by the editor when opening single files and is not really meant to be used manually. So it might require some client glue to be usable in other editors.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ported code from VSCode that enables two tsserver instances, one for "syntax" requests and one for "semantic" requests. This should ensure that the more expensive requests like semantic tokens or diagnostic computations don't block more acute requests like completions.
The default is to run with syntax and semantic servers enabled.
Resolves #650 (?)
Resolves #675 (?)