Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support .eslintrc config #708

Closed
msdrigg opened this issue Mar 27, 2023 · 2 comments
Closed

Support .eslintrc config #708

msdrigg opened this issue Mar 27, 2023 · 2 comments

Comments

@msdrigg
Copy link

msdrigg commented Mar 27, 2023

I have a .eslintrc.cjs config file for eslint to support the next.js plugin. Eslint works as expected when I run npm run lint, but when I use zed.dev integrated with typescript-language-server, I don't see these diagnostics.

I am specifically interested in the react-hooks diagnostics.

If you suspect that this is a zed.dev problem rather than a typescript-language-server problem, please let me know how I can validate that this problem is caused by typescript-language-server

@rchl
Copy link
Member

rchl commented Mar 27, 2023

This server has nothing to do with eslint. It doesn't integrate with it

There might exist typescript plugins that run eslint but it's out of scope of this server if Zed is using those. I would anyway recommend running a separate LSP server for eslint.

@rchl rchl closed this as not planned Won't fix, can't repro, duplicate, stale Mar 27, 2023
@msdrigg
Copy link
Author

msdrigg commented Mar 27, 2023

Oof—I am sorry for the confusion here.

I got the idea that eslint was integrated from this issue. #159

Seeing your response, I see the confusion around internal use of eslint vs integration of eslint. Sorry for the confusion. Thanks for the quick response :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants