fix: add folder filter in server capabilities for willRename
#814
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rchl
changed the title
|
Please cherry pick d9c102d from this repo. I've added tests and fixed linting issues. |
rchl
approved these changes
Nov 17, 2023
rchl
changed the title
willRename
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
typescript-language-server does support willRenameFiles on
folderbut it only provides filter forfile, other servers like rust-analyzer explicitly specify this filter. The absence of this filter also causes issues in willRenameFiles implementation on the client side if the client only tracks things specified by the filters, i.e it doesn't send requests on folder renamed.