Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Warning on deleted documents #74

Closed
junecv opened this issue Jan 23, 2024 · 3 comments
Closed

Warning on deleted documents #74

junecv opened this issue Jan 23, 2024 · 3 comments

Comments

@junecv
Copy link

junecv commented Jan 23, 2024

Description

Warning of "Snapshot has no readTime. Using now()" appears for every document deleted on firebase.

Steps to reproduce

const targetValue = keysToDelete[i];
await productsCollectionRef.doc(targetValue).delete();

Expected Behavior

Complete without warning

Actual Behavior

Warning appears:

{
  "textPayload": "Snapshot has no readTime. Using now()",
  "insertId": "insertID",
  "resource": {
    "type": "cloud_function",
    "labels": {
      "region": "us-central1",
      "project_id": "abc",
      "function_name": "ext-firestore-typesense-search-indexToTypesenseOnFirestoreWrite"
    }
  },
  "timestamp": "2024-01-23T11:46:16.279665Z",
  "severity": "WARNING",
  "labels": {
    "runtime_version": "nodejs16_20240114_16_20_2_RC00",
    "execution_id": "executionID",
    "instance_id": "instanceID"
  },
  "logName": "projects/abc/logs/[cloudfunctions.googleapis.com](http://cloudfunctions.googleapis.com/)%2Fcloud-functions",
  "trace": "projects/abc/traces/traceID",
  "receiveTimestamp": "2024-01-23T11:46:16.538363409Z"
}

Metadata

Typesense Version: <1.2.0

OS: MacOS 14.2.1 (23C71)

@jasonbosco
Copy link
Member

@junecv I've noticed this error in some my tests too.

I did some quick exploration on what this means and I found this StackOverflow answer which says this is expected when there are too many writes triggered in quick succession on the same document: https://stackoverflow.com/a/75908156/123545

Question for you: since this log line has a warning level, I wonder if it's non-critical? Do you see the actual changes reflected in Typesense, despite the error?

@junecv
Copy link
Author

junecv commented Jan 23, 2024

@jasonbosco I found the StackOverflow answer too before reaching out. In my case, the function is dedicated to delete a list of doc ID in Firestore. And the fact that each deletion (but not other read/write) has such warning makes me curious.

To your question, no, nothing wrong that I can see. Feel free to close the issue as you see appropriate.

@jasonbosco
Copy link
Member

Glad to know that the delete does succeed in Typesense.

I'll close this issue for now, but in case someone stumbles on this issue in the future and has any additional thoughts / ideas, please feel free to post them in this thread.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants