Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

whereIns are not handled #19

Closed
viv-design opened this issue Jan 26, 2022 · 6 comments
Closed

whereIns are not handled #19

viv-design opened this issue Jan 26, 2022 · 6 comments
Labels
good first issue Good for newcomers

Comments

@viv-design
Copy link

protected function filters(Builder $builder): string
{
return collect($builder->wheres)
->map([
$this,
'parseFilters',
])
->values()
->implode(' && ');
}

@hi019
Copy link
Collaborator

hi019 commented Jan 26, 2022

Hey, thanks for the report. I'll accept a PR for this and your last issue. I'm busy right now so it will take me a while to fix them

@cephee
Copy link
Contributor

cephee commented Apr 25, 2022

@devaygun
Copy link

devaygun commented Jul 4, 2022

@hi019 any chance we can get the open PR for this approved?

@devaygun
Copy link

devaygun commented Jul 4, 2022

Simple workaround for others encountering this:

foreach ($filters as $filter) {
    $query->where('filter', $filter);
}

Nevermind - I just realised this behaves more as AND rather than OR

@manavo
Copy link
Contributor

manavo commented Feb 27, 2023

#27 is merged, does that mean this can be closed?

@karakhanyans
Copy link
Collaborator

@manavo I need to verify that it works, then I'll close this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

8 participants