You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
@kishorenc We actually do have a Configuration class in the Ruby Client: link.
It's just that the configuration for the nodes themselves (a property inside the config class) uses a hash, rather than another class. I've rarely seen Ruby gems use another class inside the configuration class...
@jasonbosco I think this issue is no longer relevant with the class-based approach, where I presume we will have a constructor that will take the server address, port etc.?
@kishorenc I just replicated the same hash structure when doing Typesense::Client.new. Internally, the hash is converted to a Config class to make it easy to do validations.
Using a configuration class when doing .new seems non-idiomatic to me. So I prefer the hash structure.
See this line:
https://github.com/wreally/typesense-python/blob/master/examples/collection_operations.py#L3
It would be good to have a proper configuration class for the Ruby client too, rather than using a dictionary/hashmap.
The text was updated successfully, but these errors were encountered: