Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Setup tests to run on CI server #1

Closed
jasonbosco opened this issue Jan 18, 2017 · 3 comments
Closed

Setup tests to run on CI server #1

jasonbosco opened this issue Jan 18, 2017 · 3 comments
Assignees

Comments

@jasonbosco
Copy link
Member

jasonbosco commented Jan 18, 2017

CircleCI: https://circleci.com/gh/wreally/typesense.

Need to build test env so tests can run consistently.

Dependency on #2

@jasonbosco jasonbosco self-assigned this Jan 18, 2017
@jasonbosco
Copy link
Member Author

@kishorenc

I'm trying to build the docker development image (for using it in CircleCI) and I see this:

$ docker build --file $PROJECT_DIR/docker/development.Dockerfile --tag typesense/typesense-development:latest $PROJECT_DIR/docker
Sending build context to Docker daemon  7.168kB
Step 1/24 : FROM typesense/ubuntu-10-04-gcc:6.4.0
pull access denied for typesense/ubuntu-10-04-gcc, repository does not exist or may require 'docker login'

I noticed a typo in the image name: the image in Docker Hub reads ubuntu-10.04... (notice the dot after 10) but the Dockerfile has 10-04 (notice the hyphen vs dot). I tried updating the development.Dockerfile to 10.04 and re-ran docker build and now it says:

$ docker build --file $PROJECT_DIR/docker/development.Dockerfile --tag typesense/typesense-development:latest $PROJECT_DIR/docker
Sending build context to Docker daemon  7.168kB
Step 1/24 : FROM typesense/ubuntu-10.04-gcc:6.4.0
manifest for typesense/ubuntu-10.04-gcc:6.4.0 not found

Looking at the tags in Docker Hub, it looks like the latest tag on Docker Hub for that image is 4.9.2, but the Dockerfile references 6.4.0.

Could you push that tag typesense/ubuntu-10.04-gcc:6.4.0 to Docker Hub?

@kishorenc
Copy link
Member

Must have made a typo when I rebuilt that image last week. I've pushed typesense/ubuntu-10.04-gcc:6.4.0. Be sure to update docker-build.sh to match that.

@jasonbosco
Copy link
Member Author

Works now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants