Documents with duplicate IDs

[jasonbosco]

Description

Looks like currently you can create multiple documents with the same ID. Was this intended?

Then when you try to retrieve a document (with duplicate IDs), only the last document is returned. Although the search endpoint retrieves all the documents.

Steps to reproduce

$ curl "${TYPESENSE_HOST}/collections" \
       -X POST \
       -H "Content-Type: application/json" \
       -H "X-TYPESENSE-API-KEY: ${TYPESENSE_API_KEY}" \
       -d '{
             "name": "companies",
             "fields": [
               {"name": "company_name", "type": "string" },
               {"name": "num_employees", "type": "int32" },
               {"name": "country", "type": "string", "facet": true }
             ],
             "token_ranking_field": "num_employees"
          }' 

{
  "name": "companies",
  "num_documents": 0,
  "fields": [
    {"name": "company_name", "type": "string" },
    {"name": "num_employees", "type": "int32" },
    {"name": "country", "type": "string", "facet": true }
  ],
  "token_ranking_field": "num_employees"
}

$ curl "${TYPESENSE_HOST}/collections/companies/documents" \
       -X POST \
       -H "Content-Type: application/json" \
       -H "X-TYPESENSE-API-KEY: ${TYPESENSE_API_KEY}" \
       -d '{
            "id": "124",
            "company_name": "Stark Industries",
            "num_employees": 5215,
            "country": "USA"
          }'

{
  "id": "124",
  "company_name": "Stark Industries",
  "num_employees": 5215,
  "country": "USA"
}

$ curl "${TYPESENSE_HOST}/collections/companies/documents" \
       -X POST \
       -H "Content-Type: application/json" \
       -H "X-TYPESENSE-API-KEY: ${TYPESENSE_API_KEY}" \
       -d '{
            "id": "124",
            "company_name": "Stark Industries",
            "num_employees": 5215,
            "country": "USA"
          }'

{
  "id": "124",
  "company_name": "Stark Industries",
  "num_employees": 5215,
  "country": "USA"
}

Expected Behavior

May be error out when a document with the same ID already exists?

Actual Behavior

Allows documents with the same ID to be indexed.

Metadata

Typsense Version: 0.8.0

OS: Ubuntu inside Docker

[kishorenc]

It's a bug. I will look into it.

[kishorenc]

@jasonbosco Fixed by 85f9887

I've republished the Docker image. Please verify and close this issue.

[kishorenc]

Made one minor change. Returning 409 Conflict when the document ID already exists, which is consistent with the collections end-point.

[jasonbosco]

Verified that it works 👍