-
-
Notifications
You must be signed in to change notification settings - Fork 558
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve exception safety with smart pointers #33
Comments
@elfring I'm generally a fan of smart pointers as raw pointers can become hard to manage. In this case, however I refrained from wrapping for a couple of reasons:
In the end, instead of adopting a mixed style, just ended up not using it anywhere. To detect and prevent leaks, we have an integration test suite (which is not part of this repo) that's run under Valgrind. |
How do you think about to improve the implementation of the member function “array::remove_index” (for example)? |
@elfring I'm sorry for going silent on this thread. We're comfortable with using raw pointers as of today, given the heavy interoperability with the C libraries we're using. We might relook this at future. Thanks for bringing this up though! |
The interoperability concerns do not matter for affected C++ classes. |
Would you like to wrap any pointer variables with the template class “std::unique_ptr”?
The text was updated successfully, but these errors were encountered: