adding more test coverage

repetere · Mar 27, 2017 · 33a432e · 33a432e
1 parent db4358d
commit 33a432e
Show file tree

Hide file tree

Showing 2 changed files with 29 additions and 1 deletion.
diff --git a/lib/connect.js b/lib/connect.js
@@ -31,7 +31,7 @@ function connect(dbpath = defaultDBPath, options = {}, lowkieConfig = {}) {
   const db = new loki(dbname, lokiDBOptions);
   const ensureAdapterFilePromise = () => {
     if (!this.config.adapterType) {
-      throw new Error('Invalid Adapter Type');
+      return Promise.reject(new Error('Invalid Adapter Type'));
     } else {
       return (this.config.adapterType === 'file')
         ? new Promise((resolve, reject) => {
@@ -76,6 +76,7 @@ function connect(dbpath = defaultDBPath, options = {}, lowkieConfig = {}) {
             });
           })
           .catch((e) => {
+            this.connection.emit('connectionError', e, { dbname, options, });
             reject(e);
           });
       });

diff --git a/test/unit/connect_spec.js b/test/unit/connect_spec.js
@@ -126,6 +126,33 @@ describe('Connect', function () {
           done();
         });
     });
+    it('should throw error on invalid adapter types and emit error', (done) => { 
+      let newLOWKIE = new lowkieClass({});
+      let lowkieConnect = lowkieConnectTest.bind(newLOWKIE);
+      let throwawayfilepath = invalidFILEPATH;
+      // expect(lowkieConnect.bind(lowkieConnect, throwawayfilepath, {}, {
+      //   overwriteInvalidJSON: false,
+      //   adapterType: false,
+      // })).to.throw(Error);
+      lowkieConnect(throwawayfilepath, {}, {
+        overwriteInvalidJSON: false,
+        adapterType:false,
+      })
+        .then(() => { 
+          // console.log('resoved here')
+          // console.log('newLOWKIE.config', newLOWKIE.config);
+          // done();
+        })
+        .catch(e => {
+          expect(e).to.be.instanceof(Error);
+          // done();
+        });
+
+      newLOWKIE.connection.once('connectionError', (e) => {
+        expect(e).to.be.instanceOf(Error);
+        done();
+      });
+    });
     // it('should emit connection error', (done) => { 
     //   let newLOWKIE = new lowkieClass({});
     //   let lowkieConnect = lowkieConnectTest.bind(newLOWKIE);