Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use harmony imports #8

Closed
cyberhck opened this issue Aug 2, 2017 · 4 comments
Closed

use harmony imports #8

cyberhck opened this issue Aug 2, 2017 · 4 comments

Comments

@cyberhck
Copy link

cyberhck commented Aug 2, 2017

Change From
import * as types from "typestyle/lib/types"
To
import types from "typestyle/lib/types"

Webpack3 has a module concatenation plugin which relies on using harmony imports. I understand this won't work just by changing imports, but if you enable allowSyntheticDefaultImports it'll work. I can create a PR if you're interested. 🙂

@basarat
Copy link
Contributor

basarat commented Aug 2, 2017

lib/types has weight 0 on bundle. So not required 🌹

@basarat basarat closed this as completed Aug 2, 2017
@cyberhck
Copy link
Author

cyberhck commented Aug 2, 2017

I'm having a hard time because of this import. Current types is not compatiable with webpack 3's module concatenation plugin.

@basarat
Copy link
Contributor

basarat commented Aug 2, 2017

"* as" is a harmony import. And the correct one at that (not synthetic)

@basarat
Copy link
Contributor

basarat commented Aug 2, 2017

I can empathise. Trying to protect you from future bugs 🌹

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants