Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change db.merge() args order or pass it an option object #47

Open
bakaburg1 opened this issue Jun 3, 2013 · 0 comments
Open

Change db.merge() args order or pass it an option object #47

bakaburg1 opened this issue Jun 3, 2013 · 0 comments

Comments

@bakaburg1
Copy link

Hi, I literally fell in love with your framework!!!

I have one suggestion though. when using .merge() is annoying to have to redeclare the 'key' arg to 'id' to set up the event handler to true. I think that it's more common in real cases to set up the event handler than to use a different key for merging than 'id'.

But of course this could be a personal point of view. So one more general solution could be to pass option via an object with defaults {key: 'id', event: 'false'} to be merged with the one passed by the user.
I usually appreciate this solution whenever there are more than 3 args in a function.

What do think about it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant