Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Command line options do nothing #109

Closed
moimael opened this issue Jul 6, 2016 · 5 comments
Closed

Command line options do nothing #109

moimael opened this issue Jul 6, 2016 · 5 comments
Labels

Comments

@moimael
Copy link

moimael commented Jul 6, 2016

Hi,

Whenever I try to add --port or --name to the command line, it does nothing and the option I pass are never set. I use 0.5.1 and it worked before.

Thanks

@typicode
Copy link
Owner

typicode commented Jul 6, 2016

Hi @moimael,

Thanks for the report. That's weird, it works for me.

$ hotel add bar -n foo -p 4000
Create ~/.hotel/servers/foo.json
Output No log file specified (use '-o app.log')
$ cat ~/.hotel/servers/foo.json 
{
  "cwd": "/Users/typicode",
  "cmd": "bar",
  "env": {
    "PATH": "...",
    "PORT": 4000
  }
}

Just in case, if you don't see anything on hotel.dev, could you try running hotel stop && hotel start and reloading the page?

@moimael
Copy link
Author

moimael commented Jul 6, 2016

Hi,
I tried what you suggested without success.
Here is what I get :

$ hotel add 'rails s -b 0.0.0.0 -p $PORT' --port 43269
Create ~/.hotel/servers/universalavenue.json
Output No log file specified (use '-o app.log')
$ cat ~/.hotel/servers/universalavenue.json
{
  "cwd": "/home/mlavault/Development/UniversalAvenue",
  "cmd": "rails s -b 0.0.0.0 -p $PORT",
  "env": {
    "PATH": "/home/mlavault/.rbenv/shims:/home/mlavault/.rbenv/bin:/usr/local/heroku/bin:/usr/lib64/qt-3.3/bin:/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/home/mlavault/.local/bin:/home/mlavault/bin"
  }
}
$ hotel add 'rails s -b 0.0.0.0 -p $PORT' --port --name test
Create ~/.hotel/servers/universalavenue.json
Output No log file specified (use '-o app.log')
$ cat ~/.hotel/servers/universalavenue.json
{
  "cwd": "/home/mlavault/Development/UniversalAvenue",
  "cmd": "rails s -b 0.0.0.0 -p $PORT",
  "env": {
    "PATH": "/home/mlavault/.rbenv/shims:/home/mlavault/.rbenv/bin:/usr/local/heroku/bin:/usr/lib64/qt-3.3/bin:/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/home/mlavault/.local/bin:/home/mlavault/bin"
  }
}

@typicode
Copy link
Owner

typicode commented Jul 6, 2016

I can reproduce the issue if I use --name/--port instead of -n/-p.

@typicode typicode added the bug label Jul 6, 2016
@typicode
Copy link
Owner

typicode commented Jul 6, 2016

should be good in v0.5.2

@moimael
Copy link
Author

moimael commented Jul 7, 2016

Thanks ! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants